From 98f3da288396f1d653640dd4353d00c68c224d2c Mon Sep 17 00:00:00 2001 From: yogevbd Date: Sun, 28 Jul 2019 20:21:59 +0300 Subject: [PATCH] Fix android unit tests --- .../core/notification/PushNotificationProps.java | 4 ++-- .../core/notification/PushNotificationTest.java | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotificationProps.java b/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotificationProps.java index 0069502..b155dfa 100644 --- a/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotificationProps.java +++ b/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotificationProps.java @@ -21,11 +21,11 @@ public class PushNotificationProps { } public String getTitle() { - return mBundle.getString("title", ""); + return mBundle.getString("title"); } public String getBody() { - return mBundle.getString("body", ""); + return mBundle.getString("body"); } public Bundle asBundle() { diff --git a/android/app/src/test/java/com/wix/reactnativenotifications/core/notification/PushNotificationTest.java b/android/app/src/test/java/com/wix/reactnativenotifications/core/notification/PushNotificationTest.java index 5da5986..c952ded 100644 --- a/android/app/src/test/java/com/wix/reactnativenotifications/core/notification/PushNotificationTest.java +++ b/android/app/src/test/java/com/wix/reactnativenotifications/core/notification/PushNotificationTest.java @@ -6,6 +6,8 @@ import android.app.NotificationManager; import android.content.Context; import android.content.Intent; import android.content.pm.ApplicationInfo; +import android.content.pm.PackageManager; +import android.content.res.Resources; import android.os.Bundle; import com.facebook.react.bridge.ReactContext; @@ -54,6 +56,8 @@ public class PushNotificationTest { @Mock private AppLifecycleFacade mAppLifecycleFacade; @Mock private AppLaunchHelper mAppLaunchHelper; @Mock private JsIOHelper mJsIOHelper; + @Mock private Resources mResources; + @Mock private PackageManager mPackageManager; @Before public void setup() throws Exception { @@ -68,7 +72,8 @@ public class PushNotificationTest { ApplicationInfo ai = mock(ApplicationInfo.class); when(mContext.getApplicationInfo()).thenReturn(ai); - + when(mContext.getResources()).thenReturn(mResources); + when(mContext.getPackageManager()).thenReturn(mPackageManager); when(mContext.getSystemService(Context.NOTIFICATION_SERVICE)).thenReturn(mNotificationManager); } -- 2.26.2