Commit 0924cf69 authored by Travis Nuttall's avatar Travis Nuttall

fix naming for react-native link

turns out react-native link takes the first file that implements
ReactPackage, so RNThreadPackage must come before BaseReactPackage
alphabetically.  Prefixed it with Thread so RNThreadPackage comes first.
parent ecb4030d
...@@ -63,7 +63,7 @@ public class RNThreadModule extends ReactContextBaseJavaModule implements Lifecy ...@@ -63,7 +63,7 @@ public class RNThreadModule extends ReactContextBaseJavaModule implements Lifecy
try { try {
ArrayList<ReactPackage> threadPackages = new ArrayList<ReactPackage>(Arrays.asList(additionalThreadPackages)); ArrayList<ReactPackage> threadPackages = new ArrayList<ReactPackage>(Arrays.asList(additionalThreadPackages));
threadPackages.add(0, new BaseReactPackage(getReactInstanceManager())); threadPackages.add(0, new ThreadBaseReactPackage(getReactInstanceManager()));
ReactContextBuilder threadContextBuilder = new ReactContextBuilder(getReactApplicationContext()) ReactContextBuilder threadContextBuilder = new ReactContextBuilder(getReactApplicationContext())
.setJSBundleLoader(bundleLoader) .setJSBundleLoader(bundleLoader)
......
...@@ -23,11 +23,11 @@ import java.util.ArrayList; ...@@ -23,11 +23,11 @@ import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
public class BaseReactPackage implements ReactPackage { public class ThreadBaseReactPackage implements ReactPackage {
private final ReactInstanceManager reactInstanceManager; private final ReactInstanceManager reactInstanceManager;
public BaseReactPackage(ReactInstanceManager reactInstanceManager) { public ThreadBaseReactPackage(ReactInstanceManager reactInstanceManager) {
this.reactInstanceManager = reactInstanceManager; this.reactInstanceManager = reactInstanceManager;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment